[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] x86: merge stuff from asm-x86/x86_64/asm_defns.h to asm-x86/asm_defns.h
> -----Original Message----- > From: Jan Beulich [mailto:JBeulich@xxxxxxxx] > Sent: Wednesday, April 30, 2014 3:30 PM > To: Wu, Feng > Cc: andrew.cooper3@xxxxxxxxxx; xen-devel@xxxxxxxxxxxxx > Subject: RE: [PATCH] x86: merge stuff from asm-x86/x86_64/asm_defns.h to > asm-x86/asm_defns.h > > >>> On 30.04.14 at 09:18, <feng.wu@xxxxxxxxx> wrote: > >> From: Jan Beulich [mailto:JBeulich@xxxxxxxx] > >> >>> On 30.04.14 at 06:56, <feng.wu@xxxxxxxxx> wrote: > >> > +#define BUILD_COMMON_IRQ() \ > >> > +__asm__( \ > >> > + "\n" __ALIGN_STR"\n" \ > >> > + "common_interrupt:\n\t" \ > >> > + STR(SAVE_ALL) "\n\t" \ > >> > + "movq %rsp,%rdi\n\t" \ > >> > + "callq " STR(do_IRQ) "\n\t" \ > >> > + "jmp ret_from_intr\n"); > >> > >> By re-ordering this patch after the one that moves this to C code, you > >> could reduce overall churn. > > > > Do you mean I should put this patch after the one moving > "common-_interrupt" > > to entry.S? > > Yes. Okay, I will follow this! my original plan is that I finish this merge patch as an independent one first, in which, I don't change anything else other than merging. Then, I can continue the SMAP patch set based on this one and do anything we need, such as, move BUILD_COMMON_IRQ to entry.S, etc. > > Jan Thanks, Feng _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |