[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: merge stuff from asm-x86/x86_64/asm_defns.h to asm-x86/asm_defns.h



>>> On 30.04.14 at 09:18, <feng.wu@xxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> >>> On 30.04.14 at 06:56, <feng.wu@xxxxxxxxx> wrote:
>> > +#define BUILD_COMMON_IRQ()                      \
>> > +__asm__(                                        \
>> > +    "\n" __ALIGN_STR"\n"                        \
>> > +    "common_interrupt:\n\t"                     \
>> > +    STR(SAVE_ALL) "\n\t"                        \
>> > +    "movq %rsp,%rdi\n\t"                        \
>> > +    "callq " STR(do_IRQ) "\n\t"                 \
>> > +    "jmp ret_from_intr\n");
>> 
>> By re-ordering this patch after the one that moves this to C code, you
>> could reduce overall churn.
> 
> Do you mean I should put this patch after the one moving "common-_interrupt" 
> to entry.S?

Yes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.