[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 16/16] xen/arm: add SGI handling for GICv3
On 04/24/2014 11:57 AM, Ian Campbell wrote: > On Tue, 2014-04-15 at 16:47 +0530, vijay.kilari@xxxxxxxxx wrote: > >> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c >> index e3d773a..2bef977 100644 >> --- a/xen/arch/arm/vgic-v3.c >> +++ b/xen/arch/arm/vgic-v3.c >> @@ -774,6 +774,85 @@ write_ignore: >> return 1; >> } >> >> +static int vgic_to_sgi(struct vcpu *v, register_t sgir) >> +{ >> + struct domain *d = v->domain; >> + int virq; >> + int irqmode; >> + int vcpuid; >> + int i; >> + unsigned long vcpu_mask = 0; >> + >> + ASSERT(d->max_vcpus < 8*sizeof(vcpu_mask)); > > We get away with an unsigned long and ASSERT on v2 because it is limited > to 8 cpus, but gic v3 supports many more. You didn't change > MAX_VIRT_CPUS in this series, did you? In which case I suppose this is > safe enough for now, but will need to be cleverer at some point in the > future. I didn't see any change of MAX_VIRT_CPUS in this series. If he plans to change it in a next version, we have to check a domain doesn't start with more than 8 CPUs when it's using VGICv2 emulation. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |