[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/shadow: Clean up use of assertions in multi.c

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
From: Tim Deegan <tim@xxxxxxx>
Date: Thu, 24 Apr 2014 13:40:18 +0200
Cc: Keir Fraser <keir@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>
Delivery-date: Thu, 24 Apr 2014 11:40:23 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

At 19:35 +0100 on 16 Apr (1397673321), Andrew Cooper wrote:
> Use BUILD_BUG_ON()s in preference to ASSERT(sizeof(foo) == sizeof (bar)).
> 
> sh_map_domain_page() is just a thin wrapper around map_domain_page(), which
> cannot fail.  Asserting its success is redundant.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Applied, thanks.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

References:
- [Xen-devel] [PATCH] xen/shadow: Clean up use of assertions in multi.c
  - From: Andrew Cooper

Prev by Date: Re: [Xen-devel] [PATCH v3 14/16] xen/arm: Add virtual GICv3 support
Next by Date: Re: [Xen-devel] [PATCH v3 16/16] xen/arm: add SGI handling for GICv3
Previous by thread: Re: [Xen-devel] [PATCH] xen/shadow: Clean up use of assertions in multi.c
Next by thread: [Xen-devel] [PATCH v5 1/2] implement is_hardware_domain using hardware_domain global
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.