[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v5 2/8] arch, arm: add consistency check to REMOVE p2m changes
- To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
- From: Julien Grall <julien.grall@xxxxxxxxxx>
- Date: Tue, 22 Apr 2014 20:27:46 +0100
- Cc: paolo.valente@xxxxxxxxxx, keir@xxxxxxx, stefano.stabellini@xxxxxxxxxxxxx, tim@xxxxxxx, dario.faggioli@xxxxxxxxxx, Ian.Jackson@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxx, julien.grall@xxxxxxxxxx, etrudeau@xxxxxxxxxxxx, JBeulich@xxxxxxxx, Arianna Avanzini <avanzini.arianna@xxxxxxxxx>, viktor.kleinik@xxxxxxxxxxxxxxx
- Delivery-date: Tue, 22 Apr 2014 19:28:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 09/04/14 14:39, Ian Campbell wrote:
On Mon, 2014-04-07 at 12:05 +0100, Julien Grall wrote:
count is only used for RELINQUISH mapping, you don't need to update here.
Not related to this patch, but the current code is:
if ( !pte.p2m.valid )
{
count++;
break;
}
count += 0x10;
memset(&pte, 0x00, sizeof(pte));
write_pte(&third[third_table_offset(addr)], pte);
count++;
}
It seems like that final count++ is unnecessary/wrong.
Right. I will send a patch to fix it.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
