Re: [Xen-devel] [PATCH v5 2/8] arch, arm: add consistency check to REMOVE p2m changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2014-04-07 at 12:05 +0100, Julien Grall wrote:
> count is only used for RELINQUISH mapping, you don't need to update here.

Not related to this patch, but the current code is:

                   if ( !pte.p2m.valid )
                    {
                        count++;
                        break;
                    }

                    count += 0x10;

                    memset(&pte, 0x00, sizeof(pte));
                    write_pte(&third[third_table_offset(addr)], pte);
                    count++;
                }

It seems like that final count++ is unnecessary/wrong.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel