Re: [Xen-devel] [PATCH v4 08/21] xen/passthrough: vtd: iommu_set_hwdom_mapping is VTD specific

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.04.14 at 15:14, <julien.grall@xxxxxxxxxx> wrote:
> This function was exported in common header. Rename it and move the 
> declaration
> in drivers/passtrough/vtd/extern.h
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

albeit if you need to do another iteration ...

> --- a/xen/drivers/passthrough/vtd/extern.h
> +++ b/xen/drivers/passthrough/vtd/extern.h
> @@ -103,4 +103,6 @@ void pci_vtd_quirk(struct pci_dev *pdev);
>  int platform_supports_intremap(void);
>  int platform_supports_x2apic(void);
>  
> +void iommu_vtd_set_hwdom_mapping(struct domain *d);

... I'd be happier if you used only one prefix, i.e. vtd_ in this case.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel