Re: [Xen-devel] [PATCH v5] tools: Fix and improve make debball

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Fri, Apr 11, 2014 at 1:11 PM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Fabio Fantoni writes ("[PATCH v5] tools: Fix and improve make debball"):
>> - Remove version from installed package name for correct update
>> - Add conffiles to manage main config files on package update
>> - Added on description that this make a build for testing only.
>>
>> Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
>
> I haven't tested this but it looks like an improvement to me.
>
> Ian/George, do you object to this change ?
>
> The effects of marking the files in /etc/ as conffiles are that
>  - when installing this .deb, it won't unconditionally overwrite
>    any existing configuration without prompting
>  - when removing it, if you want to remove the config files, you
>    need to use --purge rather than just --remove
> I think this is a useful improvement and makes the debball less
> hazardous.
>
> If you don't object to the principle then I will test this and inspect
> the .deb to make sure it has the desired contents.

There's a part of me that wonders whether it's a good idea to have
everything in /etc considered a conf file; but I can see how that's a
much more maintainable option going forward than having to keep and
update a whitelist.

Which then brings us to the question about whether a lot of the
scripts and such should be in /etc at all; but perhaps that's a
question for another time.

Regarding the general intent:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Thanks for pursuing this, Fabio.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel