Re: [Xen-devel] [PATCH] libxl_json: remove extra "break"

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-04-09 at 14:29 +0100, Wei Liu wrote:
> ... otherwise JSON array elements are not freed and memory is leaked.

How exciting!

> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I assume this isn't a recent issue so this should be a candidate for
backporting.

> ---
>  tools/libxl/libxl_json.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c
> index d2f7de8..989ac3f 100644
> --- a/tools/libxl/libxl_json.c
> +++ b/tools/libxl/libxl_json.c
> @@ -285,7 +285,6 @@ void libxl__json_object_free(libxl__gc *gc, 
> libxl__json_object *obj)
>      }
>      case JSON_ARRAY: {
>          libxl__json_object *node = NULL;
> -        break;
>  
>          for (idx = 0; idx < obj->u.array->count; idx++) {
>              if (flexarray_get(obj->u.array, idx, (void**)&node) != 0)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel