[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 13/16] xen/arm: IRQ: Store IRQ type in arch_irq_desc
On Tue, 2014-04-08 at 16:50 +0100, Julien Grall wrote: > >> I've just noticed we do the same thing in gic_dist_init. > > > > Whatever the reason for them doing it it probably make sense to do the > > same, otherwise we are just making pain for ourselves. > > > > I'm not convinced that the exynos DT doesn't also need to be fixed > > though. > > In any case we have to be able to boot any valid device tree for Linux > no matter are the values. Right. Those two statements are not contradictory though. > It seems that Linux is ignoring NONE and doesn't update the ICFGR. That makes sense actually: i.e. if DT says none then you have assume that someone (e.g. the bootloader) has done the right thing already and not touch it. > >> If you prefer I can add a common above the function to say 0 is used > >> when an error is occured. > > > > Well, this is a more global thing than this one function really. > > I can use the same solution as serial_irq callbacks, i.e returning -1 in > case of an error. OK. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |