[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 14/16] xen/arm: IRQ: Replace {request, setup}_dt_irq by {request, setup}_irq



On 04/07/2014 04:06 PM, Ian Campbell wrote:
> On Thu, 2014-04-03 at 21:42 +0100, Julien Grall wrote:
>> Now that irq_desc stores the type of the IRQ (e.g level/edge,...), we don't
>> need anymore to use specific IRQ function for ARM.
> 
> "need to use specific...for ARM any more"
> 
>> Also replace every call to dt_device_get_irq by platform_get_irq which is
>> a wrapper to this function and setup the IRQ type correctly.
> 
> Why platform_*? It's still dt specific isn't it?

I didn't want to extend dt_device_get_irq because setting arch.type
doesn't belong to the DT code.

IHMO, soon this will take another structure in parameter to get the IRQ
either from ACPI or DT.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.