Re: [Xen-devel] [PATCH v2 01/15] xen/arm: register mmio handler at runtime

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/04/2014 01:59 PM, Ian Campbell wrote:
> On Fri, 2014-04-04 at 13:54 +0100, Julien Grall wrote:
>> On 04/04/2014 01:42 PM, Ian Campbell wrote:
>>> On Fri, 2014-04-04 at 18:00 +0530, Vijay Kilari wrote:
>>>>>> +    handler->mmio_handlers[handler->num_entries++] = handle;
>>>>>> +    spin_unlock_irqrestore(&handler_lock, flags);
>>>>>> +}
>>>>>>  /*
>>>>>>   * Local variables:
>>>>>>   * mode: C
>>>>>> diff --git a/xen/arch/arm/io.h b/xen/arch/arm/io.h
>>>>>> index 8d252c0..5fc1660 100644
>>>>>> --- a/xen/arch/arm/io.h
>>>>>> +++ b/xen/arch/arm/io.h
>>>>>
>>>>> As you are modifying this header. Can you move it in
>>>> include/asm-arm?
>>>> OK.
>>>
>>> Please don't mix movement and modifications. Unless you are adding uses
>>> from outside xen/arch/arm requiring ugly relative includes there is no
>>> need to move this IMHO.
>>
>> My point was to clean up and having a single place for every headers.
> 
> Why? What your goal with this "clean up"?

His changes will basically rewrite 80% of the header. So it was a good
time to move it.

> If a header is only used by .c files in the same directory then it is
> absolutely fine for the header to live in that directory and be included
> with
>       #include "foo.h"

We have many headers in include/asm-arm which are only used on arch/arm.

Anyway it was a suggestion... nothing else.

Regards,


-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel