Re: [Xen-devel] [PATCH v2 01/15] xen/arm: register mmio handler at runtime

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-04 at 18:00 +0530, Vijay Kilari wrote:
> >> +    handler->mmio_handlers[handler->num_entries++] = handle;
> >> +    spin_unlock_irqrestore(&handler_lock, flags);
> >> +}
> >>  /*
> >>   * Local variables:
> >>   * mode: C
> >> diff --git a/xen/arch/arm/io.h b/xen/arch/arm/io.h
> >> index 8d252c0..5fc1660 100644
> >> --- a/xen/arch/arm/io.h
> >> +++ b/xen/arch/arm/io.h
> >
> > As you are modifying this header. Can you move it in
> include/asm-arm?
> OK.

Please don't mix movement and modifications. Unless you are adding uses
from outside xen/arch/arm requiring ugly relative includes there is no
need to move this IMHO.

There is already asm/io.h which relates to readl/writel and friends. If
this were to move then it would need to be to asm/mmio.h or vmmio.h
something.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel