Re: [Xen-devel] [PATCH v10 2/6] x86: dynamically attach/detach CQM service for a guest

["Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Wednesday, April 02, 2014 11:24 PM
> To: Xu, Dongxiao
> Cc: andrew.cooper3@xxxxxxxxxx; Ian.Campbell@xxxxxxxxxx;
> Ian.Jackson@xxxxxxxxxxxxx; stefano.stabellini@xxxxxxxxxxxxx;
> xen-devel@xxxxxxxxxxxxx; konrad.wilk@xxxxxxxxxx; dgdegra@xxxxxxxxxxxxx;
> keir@xxxxxxx
> Subject: Re: [PATCH v10 2/6] x86: dynamically attach/detach CQM service for a
> guest
> 
> >>> On 26.03.14 at 07:35, <dongxiao.xu@xxxxxxxxx> wrote:
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -896,6 +896,14 @@ struct xen_domctl_cacheflush {
> >  typedef struct xen_domctl_cacheflush xen_domctl_cacheflush_t;
> >  DEFINE_XEN_GUEST_HANDLE(xen_domctl_cacheflush_t);
> >
> > +struct xen_domctl_qos_type {
> > +#define _XEN_DOMCTL_pqos_cqm      0
> > +#define XEN_DOMCTL_pqos_cqm       (1U<<_XEN_DOMCTL_pqos_cqm)
> > +    uint64_t flags;
> 
> Can you remind me again why this is a flag rather than (for now)
> a single enumerator (not necessarily implemented via enum, but
> from the perspective of its meaning)?

Users may need to attach multiple QoS types in one command, so flag could cover 
it.
E.g., # xl pqos-attach domid cqm xxx yyy zzz;
BTW, this needs a slight change in libxl side.

Dongxiao


> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel