[Xen-devel] [PATCH v9 00/18] xenctx: Many changes.

[Don Slutz <dslutz@xxxxxxxxxxx>]

Add more functionality to xenctx.

Fix some bugs.

Change from v8 to v9:

  Dropped:
    v8 #17 "xenctx: Allow output for offline vcpu when"
    v8 #20 "xenctx: Ensure errno is not zero on error in"

  Ian Campbell & George Dunlap
    #3 "xenctx: Add -n (--display-stack-pages) option to":
       Re-work commit message.


  Ian Campbell
    #4 "xenctx: Add command line options -b":
       Acked-by
       Drop extra if
    #5 "xenctx: Add command line option -D":
       Acked-by
    #9 "xenctx: Add output of stack address to Call and":
       Acked-by
    #10 "xenctx: Add -m (--memory) <maddr> option to dump":
       Acked-by
    #11 "xenctx: Add error output if --all-vcpus (-C) and":
       Acked-by
       Moved hunk from #12 that should have been here.
       Added : to error message
    #12 "xenctx: Add -d (--dump-as-stack) <daddr> option to":
       Acked-by
       Moved hunk to #11 that should have been here.
       Added : to error message
    #13 "xenctx: change is_kernel_text() into kernel_addr().":
      Revert to v5.
      Initalize kernel_end to a good value.
      Add __bss_stop to be same as _end.
      Changed -k to act like it's usage.
      Add check for kernel_start & kernel_end as last test.
    #14 "xenctx: Add conversion of more registers to symbols":
      Acked-by
      s/convert/conversion/ in $subject
    #17 "xenctx: Add 16 bit output":
      Adjust commit message.
      Change global guest_word_size to 2 if !guest_protected_mode
      Fix test for == 4 to != 8 where needed
    #18 "xenctx: Fix print_ctx_32on64's print_special call":
      Acked-by


Change from v7 to v8:

  Moved v5 #17 "xenctx: Fixup options checking"
  and renamed to
      #11 "xenctx: Add error output if --all-vcpus (-C) and":
          New commit message
          make the new copy const.

  Added:
    #18: "xenctx: Add 16 bit output"
  Bug fix add:
    #19: "xenctx: Fix print_ctx_32on64's print_special call."
    #20: "xenctx: Ensure errno is not zero on error in
           xc_translate_foreign_address()"

  Changed:
    #4 "xenctx: Add command line options -b":
       Commit message adjusted.
       More CODING_STYLE changes.
       INT_MAX was too big.
    #13 "xenctx: change is_kernel_text() into kernel_addr().":
        Added more to commit message.
        Added some basic linux kernel module reporting.
        Moved kernel_end into define tree in case no symbol found.
        At some point __bss_stop was added and _end was dropped. Both
        mean end of named kernel data.
    #17 "xenctx: Allow output for offline vcpu when":        
        Also change xc_translate_foreign_address() to work.


  Ian Campbell
    #1 "xenctx: clean up usage output":
       Acked-by
    #3 "xenctx: Add -n (--display-stack-pages) option to":
       Reworked comment.
       multiple_pages => nr_stack_pages
  me: Changed usage output.
  me: Added range checking of option.
    #5 "xenctx: Add command line option -D":
       Add "...exceeds 80 characters..." to commit message
    #6 "xenctx: Add command line option -t":
       Acked-by
       Add "...exceeds 80 characters..." to commit message
    #9 "xenctx: Add output of stack address to Call and"
       Was: "xenctx: Add command line option -T (--tag-trace)"
       Drop option.
       Add new routine: print_stack_addr
    #10 "xenctx: Add -m (--memory) <maddr> option to dump":
        Add "Moved xenctx because.." to commit message
        Changed init of sopts to only have one copy of common options.
        Make common code into routine,
  me: Fixed bug with extra set bits on small widths.
    #15 "xenctx: Add output of vcpu value and state for":
       Acked-by
  me: Removed extra {}
    #16 "xenctx: Fix handling of !guest_protected_mode":
        A little more in the commit message.

Change from v6 to v7:
  Jan Beulich:
    #13: "xenctx: Add convert of more registers to symbols":
      Move reg_is_addr_mask to an x86-specific section.

Change from v5 to v6:
  Jan Beulich:
    #13: "xenctx: Add convert of more registers to symbols":
      Move reg_is_addr_mask to a common static.

Change from v4 to v5:
  Jan Beulich:
    #13 "xenctx: Add convert of more registers to symbols":
       Add reg_is_addr_mask.
    #14 "xenctx: Add output of vcpu value and state for":
       Change vcpu=3 to vcpu3. Drop online.

  George Dunlap:
    #1 "xenctx: clean up usage output":
       Reviewed-by
    #2 "xenctx: Clean up stack trace when hypercall_page not":
       Acked-by
    #3 "xenctx: Add -n (--display-stack-pages) option to":
       Adjust option to -n, --display-stack-pages.  Adjust usage message.
    #4 "xenctx: Add command line options -b":
       Add defaults to disply. Accept MAX for -l.
    #5 "xenctx: Add command line option -D":
       Add comment, move printf.
    #6 "xenctx: Add command line option -t":
       Reviewed-by
    #7 "xenctx: Change print_symbol to do the space before.":
       Acked-by
    #8 "xenctx: More info on failed to map page.":
       Acked-by
    #9 "xenctx: Add command line option -T (--tag-trace)":
       Adjust option name, usage.
    #10 "xenctx: Add -m (--memory) <maddr> option to dump":
        Remove extra #ifndef.  Make common routine print_lines().

  Added
    #16 "xenctx: Allow output for offline vcpu when"
    #17 "xenctx: Fixup options checking."


Change from v3 to v4:
  Dropped patches:
    v3 #2 "xenctx: Correct check for xc_interface_open failing (prevents 
SIGSEGV)"
       Simular code already in master
    v3 #16 "MAINTAINERS: Add XENCTX maintainer"
       Way too soon for this.

  Most:  re-sytled all adds or changes to be in CODING_STYLE.

  #1 "xenctx: clean up usage output":
    Changed from kaddr to KADDR.

  Jan Beulich:
    v3 #4 "xenctx: Add -2 (--two-pages) option to switch stack size to 8KiB"
      Converted to
    #3 "xenctx: Add -m (--multiple_pages) option to output larger stack"

  #10 "xenctx: Add -M <maddr> option to dump memory at"
     Changed from -m to -M

  Added #15 "xenctx: Fix handling of !guest_protected_mode"

  Dropped forever:

  v1 patch #11 "xenctx: Dump registers via hvm info if available"

    This was a hack to work around a bug fix that is in 4.4.0


Change from v2 to v3:
  Added patches #1, #2, #5, and #16.
  v3 #1 "xenctx: clean up usage output":
      Move all usage cleanup into it's own patch/
  v3 #2 "xenctx: Correct check for xc_interface_open failing (prevents 
SIGSEGV)":
      Move xenctx.xc_handle out of patch v2 #9 ""
  v3 #5 "xenctx: Add command line options -b and -l":
      Redo to stack dump output size adjustments
      into commanle line options.
  v3 #16 "MAINTAINERS: Add XENCTX maintainer":
       Declare this I maintain xenctx, and drop George Dunlap.

  Unchanged (other then their number)
   v3 #3 "xenctx: Clean up stack trace when hypercall_page not in symbol table"
   v3 #8 "xenctx: Change print_symbol to do the space before."
   v3 #9 "xenctx: More info on failed to map page."

  Mostly from Jan Beulich:
  v3 #4 "xenctx: Add -2 (--two-pages) option to switch stack size to 8KiB":
    * Dropped extra change about i < 10.
    * Move add to usage to the end.
  v3 #6 "xenctx: Add command line option -D (--decode-as-ascii)":
  v3 #7 "xenctx: Add command line option -t (--tag-stack-dump)":
  v3 #10 "xenctx: Add command line option -T (--tag-call-trace)":
    * Add command line option to control this.
    * More info in commit message.
  v3 #11 "xenctx: Add -m <maddr> option to dump memory at maddr.":
    * Reworked option handling to allow multiple actions to work.
    * Add check for NO_TRANSLATION where needed.
    * Support -b and -l.
  v3 #12 "xenctx: Add -d <daddr> option to dump memory at daddr as a stack.":
    * Do this patch after -m patch.
    * Reworked option handling to allow multiple actions to work.
    * Add check for NO_TRANSLATION where needed.
    * More info in commit message.
  v3 #13 "xenctx: change is_kernel_text() into kernel_addr().":
    * new name is kernel_addr().
    * Use kernel_start if set.
    * Remove other changes.
  v3 #14 "xenctx: Add convert of more registers to symbols":
    * Extract just the symbol printing code from "xenctx: Dump registers via
      hvm info if available"
  v3 #15 "xenctx: Add output of vcpu value and state for --all-vcpus":
    * Extract just the vcpu printing code from "xenctx: xenctx: Add optional 
fCPU"

  v1 patch #11 "xenctx: Dump registers via hvm info if available" has 
     been defered to the "merge xenctx and xen_hvmctx" patch set.

  v1 patch #12 "xenctx: Add optional fCPU" has been dropped.

Change from v1 to v2:
  title was: xenctx: Add an option to output more registers.
  Processed review comments.
  Jan Beulich:
    Split 1 change into 12.
    Switch to enum for is_kernel_text(), renamed to is_kernel_addr().
    Renamed vars like memAddr to mem_addr.
  Ian Campbell:
    More on is_kernel_text().


Don Slutz (18):
  xenctx: clean up usage output
  xenctx: Clean up stack trace when hypercall_page not in symbol table
  xenctx: Add -n (--display-stack-pages) option to output larger stack
  xenctx: Add command line options -b (--bytes-per-line) and -l
    (--lines)
  xenctx: Add command line option -D (--decode-as-ascii)
  xenctx: Add command line option -t (--tag-stack-dump)
  xenctx: Change print_symbol to do the space before.
  xenctx: More info on failed to map page.
  xenctx: Add output of stack address to Call and Stack Trace.
  xenctx: Add -m (--memory) <maddr> option to dump memory at maddr.
  xenctx: Add error output if --all-vcpus (-C) and [VCPU] are both
    specified.
  xenctx: Add -d (--dump-as-stack) <daddr> option to dump memory at
    daddr as a stack.
  xenctx: change is_kernel_text() into kernel_addr().
  xenctx: Add conversion of more registers to symbols
  xenctx: Add output of vcpu value and state for --all-vcpus
  xenctx: Fix handling of !guest_protected_mode
  xenctx: Add 16 bit output
  xenctx: Fix print_ctx_32on64's print_special call.

 tools/xentrace/xenctx.c | 570 ++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 473 insertions(+), 97 deletions(-)

-- 
1.8.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel