[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH V4 02/12] TestSupport.pm: introduce create_iso_xorriso for creating isos
Wei Liu writes ("[PATCH V4 02/12] TestSupport.pm: introduce create_iso_xorriso for creating isos"): > ... and convert ts-redhat-install to make use of it. Thanks: > + > + create_iso_xorriso Why the additional blank line ? > +#---------- ISO images ---------- > +sub create_iso_xorriso ($$$$;@) { > + my ($ho,$iso,$dir,$isotimeout,@xopts) = @_; > + > + target_install_packages_norec($ho, qw(xorriso)); You (sadly) mustn't put this here because multiple simultaneous executions of this function on the same host might cause multiple simultaneous invocations of apt on the same host, which would fail due to apt's locking. > - my @isogen_base= qw(-R -J -T); > + my @isogen_base= qw(-as mkisofs -R -J); I haven't checked these xorriso options; I'll take your word for them. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |