Re: [Xen-devel] [PATCH v1 1/2] xen/arm: Introduce clean_and_invalidate_xen_dcache() macro

[Oleksandr Tyshchenko <oleksandr.tyshchenko@xxxxxxxxxxxxxxx>]

> On Thu, 2014-03-06 at 15:50 +0200, Oleksandr Tyshchenko wrote:
>> This macro is very similar to clean_xen_dcache(), but it performs
>> clean and invalidate dcache.
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> Please don't add signed-off-by from other people unless they have
> explicitly given you one. Adding an S-o-b conveys a specific meaning,
> which is to certify the change under the DCO[0] which at least I haven't
> done.
>
> If someone has contributed either ideas or code then the appropriate way
> to credit them is Suggested-by or similar or a mention in the prose part
> ("Based on a suggestion by..."). Of course it would also be appropriate
> to include a CC to that person and they may then reply with an (Acked|
> Reviewed|Signed-off)-by if they think that is appropriate. If someone
> contributed code then you could also ask if they are happy/want you to
> include their S-o-b.
>
> Sorry to be picky but as I say there is a legal angle to the use of
> S-o-b.
>
> (I've not got time to properly review the actual change today, I'll do
> that next week, but at first glance it looks good, thanks)
>
> Thanks,
> Ian.
>
> [0] http://wiki.xen.org/wiki/Submitting_Xen_Patches#Signing_off_a_patch

I will try to follow the rules.
Thank you.

-- 

Oleksandr Tyshchenko | Embedded Developer
GlobalLogic
www.globallogic.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel