Re: [Xen-devel] [PATCH v2 02/15] xen/passthrough: vtd: Don't export iommu_domain_teardown

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 02/24/2014 11:34 AM, Jan Beulich wrote:
>>>> On 23.02.14 at 23:16, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
>> iommu_domain_teardown is only used internally in
>> xen/drivers/passthrough/vtd/iommu.c
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Acked-by: Ian Cambell <ian.campbell@xxxxxxxxxx>
>> Cc: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>
>> ---
>>  xen/drivers/passthrough/vtd/iommu.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/drivers/passthrough/vtd/iommu.c 
>> b/xen/drivers/passthrough/vtd/iommu.c
>> index 5f10034..a8d33fc 100644
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -1701,7 +1701,7 @@ static int reassign_device_ownership(
>>      return ret;
>>  }
>>  
>> -void iommu_domain_teardown(struct domain *d)
>> +static void iommu_domain_teardown(struct domain *d)
>>  {
>>      struct hvm_iommu *hd = domain_hvm_iommu(d);
>>  
> 
> Please build-test your changes - this was lacking the removal of
> the function's declaration from xen/iommu.h.

Actually I did the build test on x86 ... By mistake I remove the
function's declaration in the wrong patch "xen/passthrough: iommu: Split
generic IOMMU code".

I will fix it in the next patch series.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel