Re: [Xen-devel] [PATCH V4.1] mcheck, vmce: Allow vmce_amd_* functions to handle AMD thresolding MSRs

[Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>]

On 2/13/2014 2:38 AM, Jan Beulich wrote:
> >     *val = 0;
> >   
> > -    switch ( msr & (MSR_IA32_MC0_CTL | 3) )
> > +    /* Allow only first 3 MC banks into switch() */
> > +    switch ( msr & (-MSR_IA32_MC0_CTL | 3) )
> >       {
> >       case MSR_IA32_MC0_CTL:
> >           /* stick all 1's to MCi_CTL */
> I'm confused: You now add a comment as if the mask was including
> bit 4, which it doesn't. What am I missing?
Darn. Sorry about that. Will fix..
> Also, please get used to mention (commonly at the bottom of the
> commit message, after a --- separator) what changed compared to
> the previous iteration.
Okay, will do.

-Aravind.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel