Re: [Xen-devel] [PATCH OSSTEST] Configure the Calxeda fabric on host boot

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-02-12 at 12:05 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH OSSTEST] Configure the Calxeda fabric on 
> host boot"):
> > On Wed, 2014-02-12 at 11:45 +0000, Ian Jackson wrote:
> > > This shouldn't be a host property, but a global config option (or even
> > > hardcoded).  There should be a host flag for the bodge, probably
> > > "need-calxeda-bridge-fixup" or something.
> > 
> > equiv-marilith isn't suitable I take it?
> 
> Wow, that's _really_ bodgy.

I'll take that as a no ;-)

> > > And you could wrap these lines, while you're at it:
> > > 
> > > > +        target_putfile_root($ho, 10, "$images/iproute_${ver}_all.deb", 
> > > > "iproute_${ver}_all.deb");
> > > > +        target_putfile_root($ho, 10, 
> > > > "$images/iproute2_${ver}_armhf.deb", "iproute2_${ver}_armhf.deb");
> > 
> > Sure.
> > 
> > > Or replace this extensive code with something more condensed, e.g.:
> > > 
> > >   +        my @debs = map { "iproute2_${ver}_${_}.deb" } qw(all armhf);
> > 
> > This misses the iproute vs iproute2 distinction in the names, but I'll
> > see if I can get something like this to work.
> 
> Oh so it does.  Then you need to say
>    +        my @debs = "iproute_${ver}_all.deb", "iproute2_${ver}_armhf.deb";
> but you can at least spell that out only once rather than three times
> as you do...

Ack

> Ian.
> (trying to turn everything into Common Lisp)

(Ack)

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel