Re: [Xen-devel] 4.4.0-rc3 tagged

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 02/10/14 14:33, Roger Pau Monnà wrote:
> On 10/02/14 20:23, Don Slutz wrote:
> > On 02/10/14 13:59, Roger Pau Monnà wrote:
> > > On 10/02/14 19:48, Don Slutz wrote:
> > > > On 02/10/14 05:59, Roger Pau Monnà wrote:
> > > > > On 10/02/14 10:55, Ian Campbell wrote:
> > > > > > On Fri, 2014-02-07 at 16:29 +0000, Andrew Cooper wrote:
> > > > > > > On 07/02/14 16:22, Don Slutz wrote:
> > > > > > > > On 02/07/14 05:05, Ian Campbell wrote:
> > > > > > > > > On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote:
> > [snip]
> > > > > > > Which, according to google, was introduced in 3.09.4
> > > > > > >
> > > > > > > I think the ./configure script needs a min version check.
> > > > > > Yes, I think so too. Rob, could you advise on a suitable minimum and
> > > > > > perhaps patch tools/configure.ac and/or m4/ocaml.m4 as necessary.
> > > > > >
> > > > > > Also CCing Roger who added the ocaml autoconf stuff.
> > > > > The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/.
> > > > > Here is an untested patch for our configure script to check for the
> > > > > minimum required OCaml version (3.09.3):
> > > > >
> > > > > (remember to re-generate the configure script after applying)
> > > > Not sure if the older Autoconf (2.68) is at fault, but I get:
> > > >
> > > > dcs-xen-54:~/xen/tools>autoconf configure.ac >configure
> > > > configure.ac:14: error: possibly undefined macro: AS_IF
> > > >         If this token and others are legitimate, please use
> > > > m4_pattern_allow.
> > > >         See the Autoconf documentation.
> > > > configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR
> > > On Debian systems you need the autoconf-archive package which provides
> > > the AX_COMPARE_VERSION macro, and then you also need to run aclocal
> > > before autoconf.
> > >
> > > Roger.
> > The CentOS 5.10 system has a too old autoconf to do the rebuild, So I
> > went to a Fedora 17 system.
> >
> > It does have autoconf-archive package, nut that make no difference:
> >
> >
> > Installed:
> >    autoconf-archive.noarch 0:2012.09.08-1.fc17
> >
> > Complete!
> > dcs-xen-54:~/xen/tools>autoconf configure.ac >configure
> > configure.ac:14: error: possibly undefined macro: AS_IF
> >        If this token and others are legitimate, please use m4_pattern_allow.
> >        See the Autoconf documentation.
> > configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR
> Did you run aclocal before autoconf?
>
> Thanks, Roger.
That did what was needed.  And it looks to be working.  However, with patch:

http://lists.xen.org/archives/html/xen-devel/2014-02/msg00826.html

Which looks to be going in, the version that is checked should be changed to 
3.09.3 from 3.09.4.

Note: The commit message does not match the code.

You can add:

Tested-by: Don Slutz <dslutz@xxxxxxxxxxx>

   -Don Slutz


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel