[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] 4.4.0-rc3 tagged

On 02/10/14 05:59, Roger Pau Monnà wrote:
On 10/02/14 10:55, Ian Campbell wrote:
On Fri, 2014-02-07 at 16:29 +0000, Andrew Cooper wrote:
On 07/02/14 16:22, Don Slutz wrote:
On 02/07/14 05:05, Ian Campbell wrote:
On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote:
cc1: warnings being treated as errors
xenlight_stubs.c: In function 'Defbool_val':
xenlight_stubs.c:344: warning: implicit declaration of function
xenlight_stubs.c:344: error: expected expression before
xenlight_stubs.c: In function 'String_option_val':
xenlight_stubs.c:379: error: expected expression before 'char'
xenlight_stubs.c: In function 'aohow_val':
xenlight_stubs.c:440: error: expected expression before
Any idea on what to do about ocaml issue?
My guess is that your ocaml is too old and doesn't supply CAMLreturnT.
What version do you have?


dcs-xen-53:~>ocaml -version
The Objective Caml toplevel, version 3.09.3

    -Don Slutz

Which, according to google, was introduced in 3.09.4

I think the ./configure script needs a min version check.
Yes, I think so too. Rob, could you advise on a suitable minimum and
perhaps patch tools/configure.ac and/or m4/ocaml.m4 as necessary.

Also CCing Roger who added the ocaml autoconf stuff.
The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/.
Here is an untested patch for our configure script to check for the
minimum required OCaml version (3.09.3):

(remember to re-generate the configure script after applying)

Not sure if the older Autoconf (2.68) is at fault, but I get:

dcs-xen-54:~/xen/tools>autoconf configure.ac >configure
configure.ac:14: error: possibly undefined macro: AS_IF
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR

and the generated script is bad:

    if test "x$OCAMLC" = "xno" || test "x$OCAMLFIND" = "xno"; then :

        if test "x$enable_ocamltools" = "xyes"; then :

            as_fn_error $? "Ocaml tools enabled, but unable to find Ocaml" 


            AS_IF([test "x$enable_ocamltools" = "xyes"], [
                AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not 



   -Don Slutz

commit e49609cc7b93c2633cf5a49206cb29d6bdd612be
Author: Roger Pau Monne <roger.pau@xxxxxxxxxx>
Date:   Mon Feb 10 11:54:13 2014 +0100

     tools: check OCaml version is at least 3.09.3
Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>

diff --git a/tools/configure.ac b/tools/configure.ac
index 0754f0e..6d1e2ee 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -161,6 +161,12 @@ AS_IF([test "x$ocamltools" = "xy"], [
          AS_IF([test "x$enable_ocamltools" = "xyes"], [
              AC_MSG_ERROR([Ocaml tools enabled, but unable to find Ocaml])])
+    ], [
+        AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [3.09.4], [
+            AS_IF([test "x$enable_ocamltools" = "xyes"], [
+                AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not 
+            ocamltools="n"
+        ])
  AS_IF([test "x$xsmpolicy" = "xy"], [

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.