[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/AMD: Apply workaround for AMD F16h Erratum792

>>> On 05.02.14 at 21:54, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 05/02/2014 20:59, Aravind Gopalakrishnan wrote:
>> +        if (smp_processor_id() == 0) {
>> +            pci_val = pci_conf_read32(0, 0, 0x18, 0x3, 0x58);
>> +            if (pci_val & 0x1f) {
>> +                pci_val &= ~(0x1f);
> 0x1f is by default an int, so you use a u suffix to make it u32 to use
> as a mask.

This seems pretty pointless a request - conversion from signed to
unsigned types is well defined, even more so when the converted
value is representable by both.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.