Re: [Xen-devel] [PATCH] x86/AMD: Apply workaround for AMD F16h Erratum792

[Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>]

On Wed, Feb 05, 2014 at 08:54:42PM +0000, Andrew Cooper wrote:
> On 05/02/2014 20:59, Aravind Gopalakrishnan wrote:
> >     unsigned long long value;
> > +   u32 pci_val;
> 
> Please move this to the scope created by the lower hunk.
> 

Done

> > +            if (pci_val & 0x1f) {
> > +                pci_val &= ~(0x1f);
> 
> 0x1f is by default an int, so you use a u suffix to make it u32 to use
> as a mask.  Brackets are not really needed.
> 

Done

> > +            }
> > +        }
> > +
> 
> Indentation needs some work.  This file derives from Linux so uses tabs
> (at 8 spaces wide), rather than the Xen style of 4 spaces.
> 

Done;
Sending out changes in V2.

Thanks,
Aravind.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel