[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for xen-4.4] libxl: add option for discard support to xl disk configuration

On 02/05/2014 11:36 AM, Olaf Hering wrote:
On Wed, Feb 05, George Dunlap wrote:

Well it looks like in order to keep ABI compatibility (which I don't think
we ever promised), you're introducing this weird hack with overloading a
putative boolean value with a magic number?
Yes, thats the point. If libxl_device_disk changes then IMO the SONAME
has to change as well. And is 4.4-rc4 is the right time to do that?
Likely not. I'm fine with carry the 4.4 patch to achieve the result, and
put the other version into 4.5.

Right, and so this exposes another risk of accepting a patch so late: that of making poor interface decisions in a rush which either libxl or programs written against it have to deal with for a long time. (i.e., either we have to keep supporting the old interface, or the application developer has to special case the 4.4 interface if they want to be able to compile against it).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.