Re: [Xen-devel] [PATCH v4 16/17] x86/VPMU: Suport for PVH guests

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 02/04/2014 06:51 AM, Jan Beulich wrote:
> > > > On 21.01.14 at 20:09, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> > +        if ( is_pvh_domain(current->domain) && !(vpmu_mode & XENPMU_MODE_PRIV) 
> > )
> > +            if ( !vpmu->arch_vpmu_ops->do_interrupt(regs) )
> > +                return 0;
> Please fold chained if()s like this one.
>
> > @@ -237,7 +242,7 @@ int vpmu_do_interrupt(struct cpu_user_regs *regs)
> >               else if ( !is_control_domain(current->domain) &&
> >                         !is_idle_vcpu(current) )
> >               {
> > -                /* PV guest */
> > +                /* PV(H) guest */
> I would have expected PVH guests to use the HVM paths here, not
> the PV ones. Can you clarify why you do it the other way around?
I could go either way but because PVH uses event channels for interrupts 
I went with PV path. To use HVM route I'd need to send NMIs to the guest 
and that is currently not quite working.
-boris



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel