Re: [Xen-devel] [PATCH v4 16/17] x86/VPMU: Suport for PVH guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.01.14 at 20:09, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> +        if ( is_pvh_domain(current->domain) && !(vpmu_mode & 
> XENPMU_MODE_PRIV) )
> +            if ( !vpmu->arch_vpmu_ops->do_interrupt(regs) )
> +                return 0;

Please fold chained if()s like this one.

> @@ -237,7 +242,7 @@ int vpmu_do_interrupt(struct cpu_user_regs *regs)
>              else if ( !is_control_domain(current->domain) &&
>                        !is_idle_vcpu(current) )
>              {
> -                /* PV guest */
> +                /* PV(H) guest */

I would have expected PVH guests to use the HVM paths here, not
the PV ones. Can you clarify why you do it the other way around?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel