Re: [Xen-devel] [Patch 1/2] tools/libxc: goto correct label on error paths

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-01-28 at 11:41 +0000, George Dunlap wrote:
> On 01/27/2014 04:25 PM, Andrew Cooper wrote:
> > Both of these "goto finish;" statements are actually errors, and need to 
> > "goto
> > out;" instead, which will correctly destroy the domain and return an error,
> > rather than trying to finish the migration (and in at least one scenario,
> > return success).
> >
> > Signed-off-by: Andrew Cooper<andrew.cooper3@xxxxxxxxxx>
> > CC: Ian Campbell<Ian.Campbell@xxxxxxxxxx>
> > CC: Ian Jackson<Ian.Jackson@xxxxxxxxxxxxx>
> > CC: George Dunlap<george.dunlap@xxxxxxxxxxxxx>
> 
> Right -- I can't imagine any goodness coming from jumping to "finish" in 
> those cases...
> 
> Release-acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Acked + applied, thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel