Re: [Xen-devel] [PATCH] libxc: fix claim mode when creating HVM guest

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-01-30 at 14:38 +0000, George Dunlap wrote:
> On 01/29/2014 06:33 PM, Konrad Rzeszutek Wilk wrote:
> > On Mon, Jan 27, 2014 at 05:53:38PM +0000, Wei Liu wrote:
> >> The original code is wrong because:
> >> * claim mode wants to know the total number of pages needed while
> >>    original code provides the additional number of pages needed.
> >> * if pod is enabled memory will already be allocated by the time we try
> >>    to claim memory.
> >>
> >> So the fix would be:
> >> * move claim mode before actual memory allocation.
> >> * pass the right number of pages to hypervisor.
> >>
> >> The "right number of pages" should be number of pages of target memory
> >> minus VGA_HOLE_SIZE, regardless of whether PoD is enabled.
> >>
> >> This fixes bug #32.
> >>
> >> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >> Cc: Konrad Wilk <konrad.wilk@xxxxxxxxxx>
> >
> > And also 'Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>'
> 
> Right, well nobody has shouted, so:
> 
> Release-acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Applied. Thanks all.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel