Re: [Xen-devel] [PATCH v4 12/17] x86/VPMU: Handle PMU interrupts for PV guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.02.14 at 16:26, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 02/04/2014 06:22 AM, Jan Beulich wrote:
>>>>> On 21.01.14 at 20:08, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
>>> +        return 1;
>>> +    }
>>> +    else if ( vpmu->arch_vpmu_ops )
>> If the previous (and only) if() branch returns unconditionally, using
>> "else if" is more confusing then clarifying imo (and in any case
>> needlessly growing the patch, even if just by a bit).
> 
> Not sure I understand what you are saying here.
> 
> Here is the code structure:
> 
> int vpmu_do_interrupt(struct cpu_user_regs *regs)
> {
>       if ( !is_hvm_domain(v->domain) || (vpmu_mode & XENPMU_MODE_PRIV) )
> {
>          // work
>          return 1;
> }
>      else if ( vpmu->arch_vpmu_ops )
> {

      if ( !is_hvm_domain(v->domain) || (vpmu_mode & XENPMU_MODE_PRIV) )
{
         // work
         return 1;
}
     if ( vpmu->arch_vpmu_ops )
{
         ...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel