Re: [Xen-devel] [V0 PATCH] pvh: expose feature flags from tools for domUs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.01.14 at 13:24, Roger Pau MonnÃ<roger.pau@xxxxxxxxxx> wrote:
> On 25/01/14 02:13, Mukesh Rathor wrote:
>> @@ -455,13 +455,16 @@ static void xc_cpuid_pv_policy(
>>  
>>      if ( (input[0] & 0x7fffffff) == 0x00000001 )
>>      {
>> -        clear_bit(X86_FEATURE_VME, regs[3]);
>> -        clear_bit(X86_FEATURE_PSE, regs[3]);
>> -        clear_bit(X86_FEATURE_PGE, regs[3]);
>> -        clear_bit(X86_FEATURE_MCE, regs[3]);
>> -        clear_bit(X86_FEATURE_MCA, regs[3]);
>> +        if ( !is_pvh )
>> +        {
>> +            clear_bit(X86_FEATURE_VME, regs[3]);
>> +            clear_bit(X86_FEATURE_PSE, regs[3]);
>> +            clear_bit(X86_FEATURE_PGE, regs[3]);
>> +            clear_bit(X86_FEATURE_MCE, regs[3]);
>> +            clear_bit(X86_FEATURE_MCA, regs[3]);
> 
> Should we enable MCA/MCE flags for PVH DomUs? It looks to me like Dom0
> is the only domain that can make use of MCE/MCA.

We still have vMCE ...

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel