Re: [Xen-devel] [PATCH] libxc/unlz4: always set an error return code on failures

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-01-28 at 12:30 +0000, Jan Beulich wrote:
> >>> On 28.01.14 at 12:49, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Fri, 2014-01-24 at 09:22 +0000, Ian Campbell wrote:
> >> On Fri, 2014-01-24 at 08:01 +0000, Jan Beulich wrote:
> >> > "ret", being set to -1 early on, gets cleared by the first invocation
> >> > of lz4_decompress()/lz4_decompress_unknownoutputsize(), and hence
> >> > subsequent failures wouldn't be noticed by the caller without setting
> >> > it back to -1 right after those calls.
> >> > 
> >> > Linux commit: 2a1d689c9ba42a6066540fb221b6ecbd6298b728
> >> > 
> >> > Reported-by: Matthew Daley <mattjd@xxxxxxxxx>
> >> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >> 
> >> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > This is a pretty obvious bug fix, which is already in Linux (where this
> > code originates), so I've applied it.
> > 
> > I guess you will do the Xen side one yourself.
> 
> I was sort of hoping to get an ack from Keir, and wanted to apply
> both as a pair.

Oops, sorry!

>  Now that you did the tools side, I guess I'll call it
> trivial enough and apply the hypervisor side as is.

FWIW: Acked-By: Ian Campbell <ian.campbell@xxxxxxxxxx> on that...



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel