Re: [Xen-devel] [PATCH 3/4] move XENMEM_add_to_physmap_range handling framework to common code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.12.13 at 10:09, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Fri, 2013-12-20 at 07:58 +0000, Jan Beulich wrote:
>> >>> On 19.12.13 at 11:48, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>> > Personally I think that having two redundant ways of doing the same
>> > thing is the more pointless of the two. Especially given the need to
>> > think a bit carefully about what XENMEM_add_to_physmap_range
>> > XENMAPSPACE_gmfn_range might mean...
>> 
>> Yes, that combination is bogus whichever perspective you take.
>> To some degree also because "range" in the former name is really
>> wrong - the operation doesn't deal with a range, but with a group
>> (batch) of individual pages.
> 
> That's true. I suppose there would be no harm in 
> #define XENMEM_add_to_physmap_batch 23
> #if __XEN_INTERFACE_VERSION__ < xxx
> #define XENMEM_add_to_physmap_range XENMEM_add_to_physmap_batch.
> #endif

Indeed - patch being prepared.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel