Re: [Xen-devel] [RFC PATCH] PVH: cleanup of p2m upon p2m destroy

[Tim Deegan <tim@xxxxxxx>]

Hi,

At 18:00 -0800 on 19 Dec (1387472409), Mukesh Rathor wrote:
> On Thu, 19 Dec 2013 11:50:58 +0100 Tim Deegan <tim@xxxxxxx> wrote:
> > At 18:01 -0800 on 18 Dec (1387386115), Mukesh Rathor wrote:
> > > No, not quite, because I need to know which mfns are foreign and
> > > do put_page on them. 
> > 
> > Oh right, but you need to do that anyway -- once you've got refcounts
> > held by ept entries, you need to do _all_ entry writes through the
> > function that preserves the refcount invariant.  So
> > p2m_change_entry_type_global() has to use that function too, in case
> > either of the types it's called with is p2m_foreign.  And once that's
> > fixed, a call to s/foreign/invalid/ DTRT.
> 
> Right, right... i keep not realizing, it's there now and it's use
> will scope beyond the current PVH usage. So rather than deferring to
> when someone actually finds a use case for p2m_change_entry_type_global
> using foreign, i should be handled now. 
> 
> I'll have next, un-rushed this time, patch prob first week of jan 
> given the upcoming holidays.

Great!  Looking forward to it.  Happy holidays in the meantime. :)

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel