Re: [Xen-devel] [RFC PATCH 03/10] Add cpuid_vmware_leaves

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 12/16/13 03:13, Jan Beulich wrote:
> > > > On 13.12.13 at 19:55, Don Slutz <dslutz@xxxxxxxxxxx> wrote:
> > On 12/13/13 08:38, Andrew Cooper wrote:
> > > On 13/12/2013 10:55, Jan Beulich wrote:
> > > > > > > On 12.12.13 at 23:27, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> > > > > On 12/12/2013 19:15, Don Slutz wrote:
> > > > > > +    if ( is_viridian_domain(d) )
> > > > > > +        base += 0x100;
> > > > > > +    if ( is_vmware_domain(d) )
> > > > > > +        base += 0x100;
> > > > > > +
> > As a related question: Should I reply to each e-mail, or is the reply at the
> > thread place (like here) ok?
> Generally per-mail answers are preferred, as that makes the context
> more obvious. Occasionally you'll find that overall effect is better if
> you reply to multiple levels of contexts at once.
>
> But please, for legibility's sake, include blank lines between quoted
> text and your responses.
Thanks for the info.  I will try and remember to do this.

> > > > And it seems highly questionable to me whether having both at the
> > > > same time makes much sense.
> > > >
> > > > Plus the new function doesn't belong in xen/arch/x86/traps.c ...
> > I read this as "Change to some sort of data structure to get the answer
> > instead of a function".  This is because I do not see how to return the
> > correct data from a function if it is not in xen/arch/x86/traps.c (like
> > cpuid_hypervisor_leaves is) or called from there, which I would see as more
> > confusing.
> Just like cpuid_viridian_leaves() lives in xen/arch/x86/hvm/viridian.c,
> your new function should live in e.g. xen/arch/x86/hvm/vmware.c.
>
> Jan
Ah, I now understand.  Will move this function there.
   -Don Slutz


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel