Re: [Xen-devel] [V7 PATCH 3/7] pvh dom0: implement XENMEM_add_to_physmap_range for x86

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.12.13 at 11:41, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Wed, 2013-12-18 at 10:34 +0000, Jan Beulich wrote:
>> >>> On 18.12.13 at 11:07, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>> > The alternative is to use MEMOP_EXTENT_SHIFT/MEMOP_CMD_MASK? I'd rather
>> > avoid that if we don't have to...
>> 
>> Admittedly it's not the nicest model, but that's how other memops
>> work. Question really is whether we want to allow the inconsistency
>> here, or generally allow the modification of documented to be input
>> only interface structure fields.
> 
> If you want to fix x86 then I don't mind making arm follow suit. (If you
> wanted to do the arm change at the same time I would be very happy of
> course, it should be mechanically pretty similar to the x86 change).

I'll see how ugly it ends up being.

> We could also consider taking my fix to count forward immediately, to
> remove one inconsistency and remove the other issue afterwards, since
> coming to rely on backwards processing is a harder hole to get out of
> than going from modifying the strict to not.

Yes, we should certainly do that as a first step.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel