Re: [Xen-devel] [V7 PATCH 5/7] pvh: change xsm_add_to_physmap

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.12.13 at 01:19, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> On Tue, 17 Dec 2013 08:32:41 +0000
> "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>> >>> On 17.12.13 at 03:38, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
>> >>> wrote:
>> > In preparation for the next patch, we update xsm_add_to_physmap to
>> > allow for checking of foreign domain. Thus, the current domain must
>> > have the right to update the mappings of target domain with pages
>> > from foreign domain.
>> > 
>> > Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
>> > ---
>> >  xen/arch/arm/mm.c       |    4 ++--
>> >  xen/arch/x86/mm.c       |   18 +++++++++++++++---
>> >  xen/include/xsm/dummy.h |   10 ++++++++--
>> >  xen/include/xsm/xsm.h   |    6 +++---
>> >  xen/xsm/flask/hooks.c   |    9 +++++++--
>> >  5 files changed, 35 insertions(+), 12 deletions(-)
>> 
>> This one continues to lack an ack from Daniel, and you continue to
>> fail to Cc him...
> 
> That is incorrect. He was CC'd in the last few versions since the
> fix, and I had also ping'd him in the cover letter. Either he's on
> holiday or ... no comment (he does work for the n-s-a :-) ).... 

Cc-ing him on the cover letter in insufficient (and I'd personally
even consider that sort of spam) - he needs to be Cc-ed on the
actual patch that you want him to approve. And that's
independent of any (unfortunate) need for pings or the sending
of earlier revisions.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel