Re: [Xen-devel] [RFC PATCH 1/3] xen/hvm-save: Refactor HVM_REGISTER_SAVE_RESTORE

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.12.13 at 03:17, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> The instance id in a save record served two purposes.  For a PER_VCPU record,
> it was the VCPU id while for a PER_DOM it was just an index.
> 
> As the number of instances needs to be stored to help fix hvm_save_one() 
> later
> in this series, refactor HVM_REGISTER_SAVE_RESTORE to simplify the interface
> and prevent the buggy case of registering a PER_VCPU record with multiple
> instances.  The 'kind' can now be inferred from the number of instances.
> 
> There is now HVM_REGISTER_SAVE_RESTORE_PER_DOM() and
> HVM_REGISTER_SAVE_RESTORE_PER_VCPU() which both take fewer arguments, and 
> only
> PER_DOM() allows setting a number of instances.
> 
> There is no observable change as a result of this patch.

I think this is removing flexibilty (even if not needed by current code)
is that it disallows multiple instances of per-vCPU records. After all
the current "instance == vCPU-ID" implication is a per-save-type one,
not one baked into the interface.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel