Re: [Xen-devel] [OSSTest PATCH [RFC] 4/4] make-flight: Fedora guest tests

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On ven, 2013-12-13 at 16:49 +0000, Ian Jackson wrote:
> Dario Faggioli writes ("[OSSTest PATCH [RFC] 4/4] make-flight: Fedora guest 
> tests"):
> > +      case ${xenarch} in
> > +     amd64) fedora_domUarches="x86_64 i386";;
> > +     i386)  fedora_domUarches="";;
> > +     # No ARM for now. Fedora has, from F18 on, an ARM version, and it
> > +     # all should work, but I haven't had the chance to test it in
> > +     # standalone mode.
> > +     #armhf) fedora_domUarches="armhfp";;
> > +      esac
> > +
> > +      for domU in $fedora_domUarches ; do
> > +        for dist in "19" "20-RC1" ; do
> > +     job_create_test test-$xenarch$kern-$dom0arch-fedora$dist-$domU 
> > test-fedora xl \
> 
> This puts the Fedora arch name in the job name.  I think it would be
> better if our job names used a consistent arch naming scheme (i.e.,
> the Debian one).
> 
You mean sticking with amd64 rather than x86_64? If yes, ok, I agree and
that's easy enough.

> According to your 0/4 message, this creates a large number of new test
> jobs, but you're patching the ordinary make-flight.  So I think this
> isn't really suitable as it is.
> 
So, the "lage number of new jobs" comes from the combination of Dom0
arches and DomU arches, and from the fact that I'm testing two releases
(19 and 20RC1, as per this series). I agree that all this variation is
not necessary in regular flights, as I also tried to state myself in
0/4, so, yes, I think I can fall back to a less comprehensive set of
test jobs, like only testing _one_ release, both amd64 and i386 for
DomU, but only amd64 for dom0, like it is being done for the FreeBSD
tests... Would this work?

> Probably what we want is one or two extra jobs in the existing flights
> (for testing new Xens still work with released Fedora) and a new more
> comprehensive kind of flight for testing Fedora RCs.
> 
Ok, you mean (the final part) creating 'make-fedora-flight' with all and
only the fedora jobs, right? Yes, I guess I can do that.

Thanks for the comments,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel