Re: [Xen-devel] [PATCH] tools/libxc: Fix error checking for xc_get_{cpu, node}map_size() callers

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On gio, 2013-12-12 at 14:24 +0000, Ian Campbell wrote:
> On Wed, 2013-12-11 at 15:47 +0000, Andrew Cooper wrote:
> > c/s 2e82c18cd850592ae9a1f682eb93965a868b5f2f changed the error returns of
> > xc_get_{cpu,node}map_size() to now include returning -1.  This invalidated 
> > the
> > error checks from callers, which expected 0 to be the only error case.
> 
> I don't think 0 is a valid error value any more. Neither xc_get_max_cpus
> nor xc_get_max_nodes can return 0 and the map_size functions will round
> to 1 or more.
> 
Yep, I confirm that, after that changeset, neither
xc_get_max_{cpus,nodes}() nor xc_get_{cpu,node}map_size() return 0 as an
error anymore.

> So these could all be "< 0" tests think.
> 
Indeed.

Anyway, looks like, while I fixed the callers of the xx_get_max_xx
things in that very comment, I didn't do the same for the xx_get_*map_xx
ones. Weird, as ISTR doing so too... :-/

Anyway, thanks to Coverity for caching this and to Andrew for the patch.

I'll reply to v2 (if you're posting it) but, with the conditions
converted to "< 0", this can have my:

Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel