Re: [Xen-devel] [PATCH] tools/libxc: Fix error checking for xc_get_{cpu, node}map_size() callers

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-12-11 at 15:47 +0000, Andrew Cooper wrote:
> c/s 2e82c18cd850592ae9a1f682eb93965a868b5f2f changed the error returns of
> xc_get_{cpu,node}map_size() to now include returning -1.  This invalidated the
> error checks from callers, which expected 0 to be the only error case.

I don't think 0 is a valid error value any more. Neither xc_get_max_cpus
nor xc_get_max_nodes can return 0 and the map_size functions will round
to 1 or more.

So these could all be "< 0" tests think.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel