[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: arm: correct return value of raw_copy_to_guest_*





On 12/06/2013 05:03 PM, Ian Campbell wrote:
On Fri, 2013-12-06 at 16:00 +0000, Julien Grall wrote:

On 12/06/2013 03:25 PM, Ian Campbell wrote:
This is a generic interface which is supposed to return the number of bytes
which were not copied. Make it so and update the one incorrect caller.

This is also the same for raw_clear_guest and raw_copy_from_guest.

Oops, yes.

It seems the most of ARM code assume that these functions (or macro that
call them) will return a negative value if it's fails.

Hrm, the ones I looked at all seemed to match the return the number of
bytes not copied pattern (or more often just cared about 0 on success
and !0 otherwise). Did you find some which aren't that way?


copy_from_guest_offset is a macro which use raw_copy_from_guest.
In xenmem_add_to_physmap_range (arch/arm/mm.c), we only check if the return is negative.

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.