Re: [Xen-devel] [PATCH] xen: arm: correct return value of raw_copy_to_guest_*

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-12-06 at 16:00 +0000, Julien Grall wrote:
> 
> On 12/06/2013 03:25 PM, Ian Campbell wrote:
> > This is a generic interface which is supposed to return the number of bytes
> > which were not copied. Make it so and update the one incorrect caller.
> 
> This is also the same for raw_clear_guest and raw_copy_from_guest.

Oops, yes.

> It seems the most of ARM code assume that these functions (or macro that 
> call them) will return a negative value if it's fails.

Hrm, the ones I looked at all seemed to match the return the number of
bytes not copied pattern (or more often just cared about 0 on success
and !0 otherwise). Did you find some which aren't that way?

In any case these functions are used from common code so we probably
ought to match the interface.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel