Re: [Xen-devel] [PATCH v6 1/7] x86: detect and initialize Cache QoS Monitoring feature

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.12.13 at 11:54, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 05/12/13 09:38, Dongxiao Xu wrote:
>> +struct pqos_cqm *cqm;
> 
> This is not static, so does not live in the BSS.  It needs initialising
> to NULL, so system_supports_cqm() from the following patch doesn't
> erroneously report true before init_cqm() is called.

Since when is such data not in .bss, even more so with -fno-common
in place?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel