Re: [Xen-devel] [PATCH v2 13/16] tmem: cleanup: drop useless functions from head file

[Bob Liu <bob.liu@xxxxxxxxxx>]

On 12/03/2013 06:32 PM, Andrew Cooper wrote:
> On 03/12/13 02:19, Bob Liu wrote:
>> They are several one line functions in tmem_xen.h which are useless, this 
>> patch
>> embeded them into tmem.c directly.
>>
>> Signed-off-by: Bob Liu <bob.liu@xxxxxxxxxx>
>> ---
>>  xen/common/tmem.c          |   22 +++++++++++-----------
>>  xen/include/xen/tmem_xen.h |   27 ---------------------------
>>  2 files changed, 11 insertions(+), 38 deletions(-)
>>
>> diff --git a/xen/common/tmem.c b/xen/common/tmem.c
>> index abc9053..bdadb6e 100644
>> --- a/xen/common/tmem.c
>> +++ b/xen/common/tmem.c
>> @@ -1209,7 +1209,7 @@ obj_unlock:
>>  
>>  static int tmem_evict(void)
>>  {
>> -    struct client *client = tmem_client_from_current();
>> +    struct client *client = (struct client *)current->domain->tmem;
> 
> domain->tmem is currently a void pointer.  It does not need casting.
> 
> But as said before, domain->tmem should be turned from a void pointer to
> a client pointer.
> 

Okay, I'll do that.
And I'll rename domain->tmem to domain->tmem_client to make it more
straightforward.

Thanks,
-Bob

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel