Re: [Xen-devel] [V3 PATCH 5/9] PVH dom0: implement XENMEM_add_to_physmap_range for x86

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.12.13 at 20:49, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> On Tue, 03 Dec 2013 07:48:11 +0000
> "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>> >>> On 03.12.13 at 01:05, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
>> >>> wrote:
>> > On Mon, 02 Dec 2013 12:47:25 +0000
>> > "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>> >> And as noted a number of times before - I don't think that's
>> >> appropriate. There's nothing keeping non-PVH guests from using
>> >> this interface, and hence it should either be uniformly available
>> >> to all of them, or uniformly unavailable. I'm not intending to
>> >> apply such a half baked thing.
>> > 
>> > I am sorry for your frustration, but as I said before, doing it is
>> > not straightforward as it involves creating a new version of 
>> > XLAT_add_to_physmap which unfortunately is generated via
>> > python/shell scripts.
>> 
>> Exactly - all of the basics are being taken care of for you. You
>> don#t even need to worry about how these XLAT_* macros
>> are being generated. You only need to use them (taking other
>> similar code as reference if needed).
> 
> No, the existing macro can't be used because of extra field foreign_domid
> that needs to be copied also, not to mention the gpfns array that need 
> to be handled too. We need to create/generate a new macro because the
> foreign_domid doesn't exist in struct xen_add_to_physmap, and the gpfns
> and errs arrays need to be considered.

I didn't talk of any existing macro. What I said is once the
necessary addition to xen/include/xlat.lst was made, the
macro _would be generated_ for you.

But yes, you'd need to write the code wrapping the macro
and dealing with the array.

Anyway - as said, I'll take care of this if you feel unable to, but
this requires that your code goes in rather soon (didn't get
around yet to look at v4) so I'll have time to also deal with that
fallout.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel