Re: [Xen-devel] [V3 PATCH 7/9] pvh: change xsm_add_to_physmap

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.11.13 at 03:27, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> -static XSM_INLINE int xsm_add_to_physmap(XSM_DEFAULT_ARG struct domain *d1, 
> struct domain *d2)
> +static XSM_INLINE int xsm_add_to_physmap(XSM_DEFAULT_ARG struct domain *d1,  
> struct domain *d2, struct domain *d3)
>  {
> +    int rc;
> +
>      XSM_ASSERT_ACTION(XSM_TARGET);
> -    return xsm_default_action(action, d1, d2);
> +    rc = xsm_default_action(action, d1, d2);
> +    if ( d3 && !rc )
> +        rc = xsm_default_action(action, d1, d3);

Is this really making sense? It means that d1 has rights over both
d2 and d3. Yet there's only a single ->target field in struct domain.
I see that this is in line with xsm_mmu_update(), but rather than
accepting it on that basis I wonder whether that one's making
sense either.

In any event, function parameters should be renamed following
the ones of xsm_mmu_update().

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel