[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 1/7] x86: detect and initialize Cache QoS Monitoring feature
> -----Original Message----- > From: Xu, Dongxiao > Sent: Saturday, November 30, 2013 8:41 AM > To: Jan Beulich; Andrew Cooper > Cc: Ian.Campbell@xxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx; > stefano.stabellini@xxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxx; > konrad.wilk@xxxxxxxxxx; dgdegra@xxxxxxxxxxxxx; keir@xxxxxxx > Subject: RE: [PATCH v3 1/7] x86: detect and initialize Cache QoS Monitoring > feature > > > -----Original Message----- > > From: Jan Beulich [mailto:JBeulich@xxxxxxxx] > > Sent: Friday, November 29, 2013 11:05 PM > > To: Andrew Cooper; Xu, Dongxiao > > Cc: Ian.Campbell@xxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx; > > stefano.stabellini@xxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxx; > > konrad.wilk@xxxxxxxxxx; dgdegra@xxxxxxxxxxxxx; keir@xxxxxxx > > Subject: Re: [PATCH v3 1/7] x86: detect and initialize Cache QoS Monitoring > > feature > > > > >>> On 29.11.13 at 14:54, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > wrote: > > > However, I feel that all options relating to platform QoS should be > > > available under a "qpos" custom_param, (similar to iommu=), so we don't > > > end up with loads of new command line options with common prefixes as > > > new features are added. > > > > > > For this, I would suggest semantic like: > > > > > > pqos=[<boolean>],[max_rmids=<number>] > > > > > > Particularly, when a second qpos option is introduced, it might be > > > sensible to have individual booleans for each option, as well as a > > > global enable/disable. > > > > > > > > > I would be interested in general views from others as far as this is > > > concerned. > > > > +1 > > Okay, will modify it. For parameter name, I think "opt_cqm_rmid_count" might be better, since: - RMID may be different between different QoS options, so we need to add a "cqm_" prefix here. - opt_cqm_rmid_count indicates the number of RMIDs, while opt_max_rmids means the maximum value of RMID. Here we need users limit the number of RMID in grub command line. Thanks, Dongxiao > > Thanks, > Dongxiao > > > > > Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |