Re: [Xen-devel] [PATCH net-next v2] xen-netfront: Add support for IPv6 offloads

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> Sent: 25 November 2013 15:53
> To: Konrad Rzeszutek Wilk
> Cc: Paul Durrant; annie li; Wei Liu; xen-devel@xxxxxxxxxxxxx; Boris Ostrovsky;
> David Vrabel; Ian Campbell
> Subject: Re: [PATCH net-next v2] xen-netfront: Add support for IPv6 offloads
> 
> On Mon, Nov 25, 2013 at 03:37:23PM +0000, Wei Liu wrote:
> > On Mon, Nov 25, 2013 at 10:19:26AM -0500, Konrad Rzeszutek Wilk wrote:
> > > On Fri, Nov 15, 2013 at 05:52:59PM +0000, Paul Durrant wrote:
> > > > This patch adds support for IPv6 checksum offload and GSO when those
> > > > features are available in the backend.
> > >
> > > Wei, Annie, thoughts?
> >
> > It looks mostly the same as the backend code so I don't have much to
> > say. But I suppose there will be a V3 to have a macro called
> > IPV6_MAX_HEADER, if I understand this thread correctly.
> 
> Paul, if you're going to do this, does it make sense to have that macro
> in Xen's header? Backend and frontend both the same constant.
> 

The header parse and checksum offset code should be core IMO. I think that's 
where the #define should go. I'll file patch to pull out the common code from 
netfront and netback later. For the moment I'll keep the definition local.

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel