Re: [Xen-devel] [PATCH] xen/arm: Panic if we are unable to initialize platform timer

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 11/19/2013 02:47 PM, Ian Campbell wrote:
> On Fri, 2013-11-15 at 15:58 +0000, Stefano Stabellini wrote:
>> On Fri, 15 Nov 2013, Julien Grall wrote:
>>> The caller of xen_init_time, start_xen, doesn't check the return value
>>> of the function. Xen will silently ignore the error and continue.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>>
>> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> I did wonder if it might be worth pushing the panic down into
> platform_time_init, so that the message could be more specific. But that
> seems like it relies on platform code to be more aware of when to panic
> and to use consistent wording etc. So all in all I think it is better
> here.

I thought about this solution. I didn't find good argument for one of
these solutions. So, by default, I choose to panic in init_xen_time.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel